Skip to content

Ralph/camelcase refactoring#51

Merged
ryogrid merged 28 commits into
masterfrom
ralph/camelcase-refactoring
Mar 14, 2026
Merged

Ralph/camelcase refactoring#51
ryogrid merged 28 commits into
masterfrom
ralph/camelcase-refactoring

Conversation

@ryogrid

@ryogrid ryogrid commented Mar 14, 2026

Copy link
Copy Markdown
Owner

This pull request primarily refactors the catalog-related code for improved clarity and consistency, focusing on renaming variables and constants to follow Go naming conventions and updating usages across the codebase. It also fixes some minor issues with constant usage and plugin settings.

Refactoring for naming consistency:

  • Renamed various identifiers in lib/catalog/table_catalog.go to use Go-style capitalization and naming conventions, such as TableCatalogPageIdTableCatalogPageID, tableIdstableIDs, and log_managerLogManager. This applies to struct fields, constants, variables, and function arguments throughout the file. [1] [2]
  • Updated usages of renamed constants and variables in catalog schema definitions and test files, such as INDEX_KIND_INVALIDIndexKindInvalid and indexHeaderPageIdindexHeaderPageID. [1] [2] [3]

Code clarity and function argument improvements:

  • Changed function argument names from generic (e.g., schema_) to more descriptive (sc) in catalog and statistics code, and updated all usages accordingly. [1] [2]

Bug fixes and correctness:

  • Fixed usage of expression type constants in statistics code to use the correct enum values (e.g., EXPRESSION_TYPE_COMPARISONExpressionTypeComparison). [1] [2] [3]
  • Corrected variable naming in statistics methods for column index arguments (e.g., col_idxcolIdx).

Plugin configuration:

  • Added a .claude/settings.json file to enable the ralph-skills@ralph-marketplace plugin.

ryogrid and others added 28 commits March 14, 2026 10:50
…common/

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…/storage/page/

Renamed PageId→PageID, GetPageId→GetPageID, SetPageId→SetPageID,
MAX_FOWARD_LIST_LEN→MaxForwardListLen, rwlatch_→rwLatch, and other
snake_case identifiers to follow Effective Go conventions. Updated all
references across the entire codebase.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…nd lib/storage/buffer/

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…and lib/storage/tuple/

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…h, skip_list, btree)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ib/concurrency/

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…/planner/

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…materialization/, and lib/testing/

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…nts and snake_case variables

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ryogrid ryogrid merged commit 1db135b into master Mar 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant