Skip to content

max-rescale applies eta twice #31

Description

@jvmcoquet

Hi! Thanks for the great paper!

I believe there’s a small bug in the max-rescale implementation that applies eta twice.
In trainer_base.py, lines 714–717:

elif mode.startswith('max-rescale-'):
  sigma_max = torch.minimum(
    eta_t.expand_as(alpha_t), (1 - alpha_s) / alpha_t)
  sigma = torch.where(alpha_t > 0, sigma_max, 1) * eta

This computes:

sigma = eta * min(eta, (1 - alpha_s) / alpha_t)

but the paper specifies:

sigma = eta * min(1, (1 - alpha_s) / alpha_t)

Therefore, when the minimum selects eta, the implementation gives eta²

Activity

  1. assigned and unassigned on Sep 12, 2026
  2. s-sahoo commented on Sep 12, 2026

    @s-sahoo
    Owner

    @jdeschena could you please look into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions