Update Croppie with our fix for more smooth zooming#1
Open
s0ber wants to merge 75 commits intos0ber:masterfrom
Open
Update Croppie with our fix for more smooth zooming#1s0ber wants to merge 75 commits intos0ber:masterfrom
s0ber wants to merge 75 commits intos0ber:masterfrom
Conversation
Changes - Adds aria label to input range - Adds alt to images - Adds aria-hidden to hidden image - Add aria grabbed and drop to draggable image
- Adds label to input
- Fixes dropeffect location and state https://technet.microsoft.com/en-us/library/hh968241%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396
- Adds label to input
Accessibility 1
Set correct value for accessibility attribute when rotate picture
Accessibility
…oliotek#378) * fixes-issue-Foliotek#365 * 2.5.1 * fixes-issue-Foliotek#365 * forgot minified version
Fixed typo.
* ISSUE-397: Fix wrong imgData after zomming out. * 2.5.1 * Revert "2.5.1" This reverts commit f98da61 * Revert croppie.min.js to version 2.5.0 state * Add imgData to declaration block.
I some situations the result image is scaled out of ratio! I tagged down the problem to: Math.min(width, self._originalImageWidth) I don't know why its needed ... but if i removed it its working ok!
I added my vuejs croppie version too. :)
This typo makes it unusable in strict mode because it doesn't allow to create global variables in this way, and i believe you didn't want it too https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode#Converting_mistakes_into_errors
* Linting - avoid type coercion * Linting - remove unncessary semi colons * Fix issue with enforceBoundary = false Whenvever enforceBoundary is set to false, the image cannot get smaller the original image size. Adding conditional that will skip this check if enforceBoundary = false
…ek#499) EXIF orientation data got ignored because of commit 018d30c (which fixed displaying image when exif-js is not available). This only happens when 'enableOrientation' is true and you do not pass an orientation to 'bind'. This is for example the case when you want to add a button to rotate the image. You can reproduce this issue in the demo 'upload-demo' when you set 'enableOrientation' to true.
* fix _onZoom called twice when rotate * keep center point after rotate
The `bind` method returns a promise which mainly awaits loading the image URL. If an error happened within the image loader, then the `bind` method would simply log it to the console and the caller's promise handling would continue as if everything was fine. In addition, network issues or otherwise errors in the browser's loading of the image was not caught and propagated back up to the `bind` method. This implements a simple `onerror` handler for loading the image which rejects the loading promise. The `catch` handler in the `bind` method which swallowed any rejections have also been removed, which enables the caller to handle this properly on their side.
* Foliotek#479, Foliotek#470 - fix global definition * Fix AMD and CommonJS definition
…k#592) This change-set ensures Croppie does not attempt to use image data outside of an image’s bounds. This also ensures that the destination x/y and width/height are scaled appropriately so the image is placed where one would expect.
Fixes an issue with variables not being assigned. The issue has come from Foliotek#592
* Fixes Foliotek#515 * Added if for 180 as suggested by @bwakabats
Added a minor check to alert user that they loaded Croppie without an image.
…them during initialization to prevent breaking NodeJS by just being required/imported (Foliotek#657)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.