Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Author
|
I'll open a new PR when I find a good candidate for negative weights clipping. |
Collaborator
Author
|
@Clybius (apologies if I got the wrong handle!) came up with a more appropriate approach for the projection part of the formulae, which I just implemented. It seems to work much better on models that have a low cosine similarity from one another. On models that are similar, it resembles a weighted sum. I updated the formulae above in the OP to reflect this. I tested rebasin with add perpendicular difference and it works really well. Since plain add difference doesn't work with rebasin, I think this method might be a valuable replacement in some cases. It also doesn't need weights clipping to crank alpha up to 1. More tests needed with dj cats I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perpendicular add:
model A: https://civitai.com/models/81359?modelVersionId=86337
model B: https://civitai.com/models/108882/ink-prt
model C: SD1.5 base model from runwayml
alpha: 1.0
[image]