Fix URL validation in SocialsForm#118
Draft
Discusser wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the URL in socialsSchema was validated using a regex pattern. This pattern wasn't exhaustive, as it didn't take into account
-or_for example. I have replaced this with zod'surl()method, which uses theURLobject under the hood (see https://github.com/colinhacks/zod/blob/1f4f0dacf313a2dba45563d78171e6f016096925/src/types.ts#L820). This implementation is much more reliable and less error prone.Furthermore, an issue arises when checking the domain names for URLs. For example, LinkedIn has
linkedin.comas its only domain at the moment, which, with the current implementation, rejectswww.linkedin.com, but that is trivial to solve. The main issue is that most websites have many domain names that lead to the same page. For example, a LinkedIn link can havewww.linkedin.frorfr.linkedin.comas its hostname. It's therefore almost impossible to check if a URL is valid for a specific website, since there are too many hostnames to keep track of.For now, I have simply removed the hostname validation, but I will keep this PR as a draft until we figure out a better solution.