Skip to content

test: use context manager for read session in test_stream_ops#91

Merged
quettabit merged 1 commit into
mainfrom
qb/read-sess-tests
Jul 21, 2026
Merged

test: use context manager for read session in test_stream_ops#91
quettabit merged 1 commit into
mainfrom
qb/read-sess-tests

Conversation

@quettabit

Copy link
Copy Markdown
Member

No description provided.

@quettabit

Copy link
Copy Markdown
Member Author

@greptileai review pls

@greptile-apps

greptile-apps Bot commented Jul 21, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates the stream operation tests for the ReadSession lifecycle.

  • Uses ReadSession as an async context manager.
  • Preserves bounded reads, tailing timeouts, and error assertions.
  • Ensures sessions close after completion, cancellation, or failure.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
tests/test_stream_ops.py Updates read-session tests to enter and close sessions through the async context-manager API.

Reviews (2): Last reviewed commit: "initial commit" | Re-trigger Greptile

@quettabit
quettabit force-pushed the qb/read-sess-tests branch from ccc1f70 to eb3bb0e Compare July 21, 2026 23:42
@quettabit
quettabit marked this pull request as ready for review July 21, 2026 23:42
@quettabit
quettabit requested a review from a team as a code owner July 21, 2026 23:42
@quettabit
quettabit merged commit 7e83de4 into main Jul 21, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant