Conversation
javascript_wam_fact_sources/1 (Lua-shaped) emits CallFactStream instead of inline WAM and loads TSV/CSV or JSONL at runtime via Node fs. First-arg indexing when A1 is bound. No new npm dependency; inline facts unchanged. LMDB/CSR stay out of scope. Co-authored-by: johns243a <johns243a@gmail.com>
js_fs_probe called js_fs_has/2, which the TSV/JSONL compiles omitted. The CSV suite still exercises the caller via CLI. Co-authored-by: johns243a <johns243a@gmail.com>
s243a
marked this pull request as ready for review
August 30, 2026 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes G-W4: the JS WAM had only an empty
fact_sources: {}scaffold, so every fact had to be compiled inline.What changed
Lightweight file-backed P/2 facts, modeled on Lua's
lua_fact_sources/1:javascript_wam_fact_sources([source(P/2, file(Path))])(aliasjs_fact_sources/1).I.CallFactStream+I.Proceed()instead of inline WAM.[a,b],{a1,a2},{args:[...]}) viafs.readFileSync. No npm deps.fact_streamchoice point.parse_term(int/float/atom/compound).LMDB / CSR are out of scope (same as Lua).
Tests (green locally)
Parser probes, 48-query local suite, and lowered emitter stay green.
Branching
Branched from
grok/wamjs-parserand extended it (net additions). Shared files are not edited (INTEGRATION_PATCH.mdunchanged).