Conversation
There was a problem hiding this comment.
Pull request overview
This PR focuses on cleanup and more robust error handling across the flow runtime and executor code paths.
Changes:
- Simplifies redundant error construction and adds Redis command error checks in the runtime.
- Fixes JSON struct tags for executor requests (ensuring proper marshal/unmarshal behavior).
- Prevents potential nil dereferences during executor cleanup and adds error handling around data store copying.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
runtime/flow_runtime.go |
Removes redundant fmt.Sprintf usage and adds error handling for Redis Set/Del. |
core/sdk/executor/request.go |
Fixes invalid JSON tags and a minor comment formatting issue. |
core/sdk/executor/executor.go |
Adds nil-guards for dataStore.Cleanup(), improves failure logging, and handles CopyStore() errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: s8sg <7374058+s8sg@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR focuses on cleanup and more robust error handling across the flow runtime and executor code paths.
Changes:
Simplifies redundant error construction and adds Redis command error checks in the runtime.
Fixes JSON struct tags for executor requests (ensuring proper marshal/unmarshal behavior).
Prevents potential nil dereferences during executor cleanup and adds error handling around data store copying.