chore: reuse GitHub hygiene workflows#176
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 242e31476b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| git-hygiene: | ||
| uses: saagpatel/sovereign/.github/workflows/git-hygiene.yml@main | ||
| secrets: inherit |
There was a problem hiding this comment.
Avoid inheriting all secrets into shared workflow
On same-repository PR events, secrets: inherit implicitly exposes every available repository/org secret to the reusable workflow in saagpatel/sovereign@main, whereas the removed local jobs only used GITHUB_TOKEN. Because this hygiene check only needs token-scoped GitHub access, pass only the named token/permissions it needs or omit inherited secrets; the same exposure is introduced in lockfile-rationale.yml as well.
Useful? React with 👍 / 👎.
242e314 to
33d5052
Compare
33d5052 to
dcfe32e
Compare
Summary
Merge order
Lockfile rationale
Verification