Allow multiple template paths#227
Open
a-babarytskyi wants to merge 1 commit into
Open
Conversation
updating type annotation, since jinja accepts list of paths and will look for potential templates in all of them.
Owner
|
Hey @a-babarytskyi! Thanks looking into it. Okay jinja can accept list of paths, but is fastapi-mail supports this? Also, naming convention wont be correct in this case for template folder, s letter should have at the end. Another question raises, do we have tests for this case? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating type annotation, since jinja accepts list of paths and will look for potential templates in all of them. Especially helpfull if you have a lot of templates that rely on similar base higher in hierarchy.
No other changes required, tested locally.