Repository navigation
fix: stabilize command palette appearance and focus - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #27 by giving the command palette stable foreground contrast in both Light and Dark appearances while preserving native macOS translucency and the invoking app's active state.
What is the purpose of this pull request?
Changes
NSPanelwith native HUD material.Testing
Screenshots
The palette was visually checked in Light and Dark appearances over both bright and dark application backgrounds. The invoking window's active traffic-light state was also verified while the palette was visible.
Checklist
QA
printf 'yes\nno\n' | mac-menu. The palette should remain light with dark, legible text.Closes