Add CI matrix, ruff config and fix the lint it found - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI (
.github/workflows/ci.yml) runs the suite on ubuntu / windows / macos against Python 3.9 and 3.12 - the declared floor and a current release - plus a CLI smoke test and apython -m buildcheck. The suite is standard-library only and opens no sockets, so it runs unchanged on a sandboxed runner with no egress.Ruff config selects
E,F,W,I,B,C4.UP(pyupgrade) is deliberately excluded and the reasoning is in a comment inruff.toml: it wantsDict[str, int]rewritten todict[str, int]andOptional[X]toX | None, which this codebase avoids on purpose while 3.9 is the supported floor. Turning it on meant 68 findings that were all style disagreements rather than defects.The genuine findings are fixed here: unsorted imports, a redundant
open()mode, an unusedIteratorimport, and two over-length lines.F401is scoped tocommands.pyonly, where the unused imports are the registry mechanism rather than an oversight.Also adds
.gitignore-netprobe.iniis ignored whilenetprobe.ini.examplestays tracked as the template.ruff check .is clean and all 84 tests pass locally.