Skip to content

Expand README with worked examples for every command - #16

Merged
saeed205 merged 1 commit into
mainfrom
readme-docs
Aug 19, 2026
Merged

saeed205 merged 1 commit into
mainfrom
readme-docs

Conversation

@saeed205

Copy link
Copy Markdown
Owner

The README was a stub from the scaffolding PR and never caught up with the six commands that landed after it.

Now documents each command with real console output rather than just a flag list, plus the parts that are not guessable from --help:

  • exit status table - 0 success, 1 check failed, 2 usage, 130 interrupted. This is the contract that makes netprobe subnet 10.0.0.0/8 --contains X && ... and monitoring checks work, and it was undocumented
  • JSON shape - single-result commands emit an object, list commands emit an array, so consumers never index [0] for a scalar
  • config precedence - command line always beats the file
  • the /31 and /32 handling, and why latency uses TCP rather than ICMP

Adds CI, Python version and license badges.

@saeed205
saeed205 merged commit 98082d9 into main Aug 19, 2026
@saeed205
saeed205 deleted the readme-docs branch August 19, 2026 16:31

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4a1adecbe6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md

```bash
netprobe http example.com
netprobe http example.com -L # walk every redirect hop

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Document the ten-hop redirect limit

For redirect chains longer than ten hops, follow() stops when len(hops) == max_hops (default 10), so -L does not walk every redirect hop or show the terminal response. This comment overpromises the behavior precisely for long or looping chains where complete redirect diagnostics matter; describe the ten-hop limit instead.

Useful? React with 👍 / 👎.

Comment thread README.md
python -m ruff check .
```

84 tests, no test dependencies to install. See [CONTRIBUTING.md](CONTRIBUTING.md).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the link to the missing contribution guide

The reviewed commit contains no CONTRIBUTING.md anywhere in its repository tree, so this development link is guaranteed to lead readers to a 404. Add the referenced guide or remove the link.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant