Conversation
garnold54
left a comment
garnold54
left a comment
There was a problem hiding this comment.
Thanks Amber! As discussed, some changes we can make around how users pass in the job status filters to support the old flags from v3 in the v4 implementation, and add some new ones for the new status instead of passing them in as the string array.
I think it would be nice to try and support the user-name flag in v4 as well even though we would now have to make a separate call to the accounts endpoint to get the user id first.
amberxu25
force-pushed
the
FMEFLOWCLI-57
branch
from
1ab38c1 to
0ca2239
Compare
…atuses from both groups; avoided querying queued jobs when --engine-name is given
garnold54
left a comment
garnold54
left a comment
There was a problem hiding this comment.
Thanks Amber! Just a suggestion on I think making the code a bit easier to read by moving some logic around. Let me know if you want to discuss!
garnold54
left a comment
garnold54
left a comment
There was a problem hiding this comment.
Looking great! Just two more things:
- For the things that are new for v4, maybe we should provide a nice error message besides the 404 that is returned if they are used with the v3 API.
- We should regenerate the docs so they match 1 to 1 with the help from the commands. See this readme for info: https://github.com/safesoftware/fmeflow-cli/tree/main/docgen
garnold54
left a comment
garnold54
left a comment
There was a problem hiding this comment.
Just one more change to move the V4 only in the help text, then we should be good to merge!
garnold54
left a comment
garnold54
left a comment
There was a problem hiding this comment.
Awesome! I think we are ready to merge! 👍 Thanks!
2 participants
FMEFLOWCLI-57