Repository navigation
Hygiene: crate-prefixed codec examples, cargo fmt, clippy clean - #61
Merged
Merged
Conversation
…clippy clean Each codec repo's develop now has: examples renamed with a crate prefix (bench -> <crate>_bench, kernels -> mpeg2_/prores_kernels, ivfenc/ivfdec -> av1_/vp9_..., and so on), so `cargo build --workspace --all-targets` no longer links two same-named example binaries into target/<profile>/examples (LNK1104 on Windows); one mechanical `cargo fmt --all` commit; clippy clean under --all-targets --all-features -D warnings (h26x's fixes verified bit-exact against all 427 conformance streams and the encoder identity grid); and rustfmt/clippy gates in each repo's CI.
Mechanical: the output of `cargo fmt --all` (rustfmt 1.10), nothing else. Hand-aligned data tables keep their layout under #[rustfmt::skip].
…re-free feature Checked with every feature that builds without hardware or a CUDA toolkit (server, batch, image, thumbnail, ipc, qsv, nvidia, amd, the software fallbacks, dpir); dpir-cuda / dpir-cudnn need nvcc and are left out. Fixed: chunks_exact_to_as_chunks, collapsible_if, manual_is_multiple_of, manual_repeat_n, clone_on_copy, question_mark, bool_assert_comparison, needless_borrow, vec_init_then_push, unnecessary_min_or_max, err_expect, collapsible_match, manual_range_patterns, while_let_loop, useless_conversion, single_match, redundant_closure, derivable_impls, useless_format, field_reassign_with_default, assertions_on_constants (now const asserts), duplicated_attributes, doc_lazy_continuation, type_complexity in codec (a type alias). Allowed, with the reason beside each: crate-wide too_many_arguments in rivet-container (box and track writers) and type_complexity in rivet-transcoder (parsers' tuple returns); at the item, large_enum_variant on the CLI's Command, codec's h26x Inner and dpir Net (one instance each), needless_range_loop where an index also addresses other buffers, and too_many_arguments on pad_plane and one test helper.
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code-only hygiene pass. The CI gate is a separate small PR that follows this one.
Submodule bump (every codec repo, now on its develop head)
bench-><crate>_bench,kernels->mpeg2_kernels/prores_kernels,ivfenc/ivfdec->av1_*/vp9_*, and so on.cargo build --workspace --all-targetsno longer links two same-named binaries intotarget/<profile>/examples, which failed on Windows with LNK1104 when parallel links raced on the same.exe.cargo fmt --allcommit per repo. Hand-aligned data tables keep their layout under#[rustfmt::skip].--all-targets --all-features -D warnings. h26x was the only one with findings (about 310).cargo fmt --all --checkand clippy with--all-features.This repo
cargo fmt --all, a mechanical commit on its own.--workspace --all-targets -D warningswith every feature that builds without hardware or a CUDA toolkit.dpir-cudaanddpir-cudnnneed nvcc and are left out.