Skip to content

Fix workflow catalogue layout overflow - #583

Open
Mochael wants to merge 1 commit into
mainfrom
fix/workflow-catalogue-layout
Open

Fix workflow catalogue layout overflow#583
Mochael wants to merge 1 commit into
mainfrom
fix/workflow-catalogue-layout

Conversation

@Mochael

@Mochael Mochael commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep catalogue action buttons within the same card width
  • truncate long source filenames with an ellipsis
  • expose the full source filename on hover

Verification

  • pnpm -s --filter @libretto/website type-check
  • pnpm -s lint
  • local browser layout check

@Mochael Mochael added the bug Something isn't working label Aug 17, 2026
@vercel

vercel Bot commented Aug 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
libretto Ready Ready Preview Aug 17, 2026 8:48pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
libretto-docs Ignored Ignored Preview Aug 17, 2026 8:48pm

@github-actions

Copy link
Copy Markdown

OpenCode Review

📋 Detailed Review

Spec Analysis

No spec file exists. Inferred goals: keep workflow catalogue card actions from exceeding card width, make long source filenames truncate with an ellipsis, and expose full source filenames on hover.

Changed Files

  • apps/website/src/HostedWorkflowsPage.tsx: Overrides the button min-width so the action button can fit inside its card.
  • apps/website/src/SourceBrowser.tsx: Adds filename hover text and adjusts filename button overflow/truncation classes.

Simplicity Assessment

  • apps/website/src/HostedWorkflowsPage.tsx:1047 uses a single targeted utility override for the existing button min-width. This is the smallest practical change for that component.
  • apps/website/src/SourceBrowser.tsx:52 adds the native title attribute instead of adding tooltip state or a custom component, which keeps the hover behavior simple.
  • apps/website/src/SourceBrowser.tsx:54-60 keeps the truncation behavior local to the source file button and text span. No extra abstraction appears to be added.

Correctness Assessment

  • apps/website/src/SourceBrowser.tsx:54-60 does not fully satisfy the stated filename truncation goal below the lg breakpoint. The button remains shrink-0 with no mobile width or max-width constraint, and lg:overflow-hidden only applies on large screens, so a long filename can size the button to its full content width instead of producing an ellipsis.

Summary

The implementation is small and mostly matches the PR goals. The card action button fix looks targeted, and the full filename hover text is correctly exposed with title.

Required Actions

  • apps/website/src/SourceBrowser.tsx:54-60: Long source filenames still will not truncate on mobile because the button has no constrained width below lg. Failure mode: the filename button grows to content width, so truncate has no effective width to clip against. User impact: mobile users do not get the promised ellipsis behavior for long filenames. This blocks merge because filename truncation is one of the core stated goals of the PR.

Suggestions

None

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant