fix: ask user before proceeding when corpus fits in context window#376
Open
sanchaymittal wants to merge 1 commit intosafishamsi:v4from
Open
fix: ask user before proceeding when corpus fits in context window#376sanchaymittal wants to merge 1 commit intosafishamsi:v4from
sanchaymittal wants to merge 1 commit intosafishamsi:v4from
Conversation
When detect() returns a non-empty warning field (e.g. "Corpus fits in a single context window"), the skill silently ignored it and ran the full pipeline anyway — burning tokens on semantic subagents unnecessarily. Add a check: if warning is non-empty, display it and ask the user whether to proceed or answer directly without building a graph. Applies to skill.md and all platform variants (aider, claw, codex, copilot, droid, kiro, opencode, trae, windows).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
detect()returns a non-emptywarningfield (e.g."Corpus is ~5,005 words - fits in a single context window. You may not need a graph."), the skill's Step 2 action list silently ignored it and fell through toOtherwise: proceed directly— running the full pipeline, dispatching semantic subagents, and burning tokens unnecessarily.The warning existed in the library output but had no corresponding stop-and-ask logic in the skill.
Fix
Add a check between the large-corpus branch and the
Otherwisefallthrough:Applied to
skill.mdand all platform variants (skill-aider.md,skill-claw.md,skill-codex.md,skill-copilot.md,skill-droid.md,skill-kiro.md,skill-opencode.md,skill-trae.md,skill-windows.md).Test plan
/graphifyon a small repo (<10 files, <10k words) — should display the warning and pause for confirmation/graphifyon a large repo (>10k words, no warning) — should proceed as before without prompting