fix: add missing sys import in watch.py#392
Open
shaun0927 wants to merge 1 commit intosafishamsi:v4from
Open
Conversation
watch() references sys.platform at line 150 to select PollingObserver on macOS, but sys was never imported. This causes NameError on all platforms when running graphify watch. Introduced in v0.4.15 by the macOS PollingObserver change (safishamsi#373).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #386.
watch()referencessys.platformat line 150 to selectPollingObserveron macOS, butsyswas never imported. This causesNameErroron all platforms when runninggraphify watch.Introduced in v0.4.15 by #373 (macOS PollingObserver change).
Change
One line:
import sysadded to module imports ingraphify/watch.py.Testing
Full test suite: 433 passed, 0 failures.