fix: add .mjs to AST extractor dispatch table#393
Open
shaun0927 wants to merge 1 commit intosafishamsi:v4from
Open
fix: add .mjs to AST extractor dispatch table#393shaun0927 wants to merge 1 commit intosafishamsi:v4from
shaun0927 wants to merge 1 commit intosafishamsi:v4from
Conversation
.mjs was added to CODE_EXTENSIONS in detect.py (v0.4.15) but not to the _DISPATCH table in extract(), so .mjs files are detected and counted in corpus metrics but silently produce zero nodes/edges. Adds ".mjs": extract_js — .mjs is standard ES module JavaScript, parsed identically to .js by tree-sitter-javascript. Partial fix for safishamsi#365.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #387 (and #365).
.mjswas added toCODE_EXTENSIONSindetect.py(v0.4.15) but not to the_DISPATCHtable inextract(), so.mjsfiles are detected and counted in corpus metrics but silently produce zero nodes/edges during extraction.Change
One line:
".mjs": extract_jsadded to_DISPATCHingraphify/extract.py..mjsis standard ES module JavaScript — same language as.js, just with explicit module syntax. tree-sitter-javascript handles both identically.Testing
Full test suite: 433 passed, 0 failures.
Note on .ejs
.ejshas the same dispatch gap but EJS is an HTML templating engine, not pure JavaScript. It may be better suited toDOC_EXTENSIONSfor semantic extraction. Left for separate discussion in #387.