Skip to content

allow responsive viewport size #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EarthmanWeb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

allow responsive viewport size #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/browser-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ export class BrowserManager {
browserType: config.browserType,
headless: config.headless,
viewport: config.viewport,
responsive: config.viewport === null,
proxy: effectiveProxy,
metadata
},
Expand Down
10 changes: 8 additions & 2 deletions src/tools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,12 @@ export class BrowserTools {
width: { type: 'number', default: 1280 },
height: { type: 'number', default: 720 }
},
description: 'Viewport size'
description: 'Viewport size (ignored if responsive is true)'
},
responsive: {
type: 'boolean',
description: 'Enable responsive mode with no fixed viewport (passes null to Playwright)',
default: false
},
userAgent: {
type: 'string',
Expand Down Expand Up @@ -500,7 +505,8 @@ export class BrowserTools {
{
browserType: args.browserType || 'chromium',
headless: args.headless ?? true,
viewport: args.viewport || { width: 1280, height: 720 },
viewport: args.responsive ? null : (args.viewport || { width: 1280, height: 720 }),
responsive: args.responsive ?? false,
userAgent: args.userAgent
},
args.metadata
Expand Down
3 changes: 2 additions & 1 deletion src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ export interface BrowserConfig {
viewport?: {
width: number;
height: number;
};
} | null;
responsive?: boolean;
userAgent?: string;
proxy?: ProxyConfig;
contextOptions?: {
Expand Down