Skip to content

Refactor: Extract URL parsing logic and improve code organization #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sak0a merged 4 commits into from
Feb 13, 2026
Merged

Refactor: Extract URL parsing logic and improve code organization #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5bcb043
refactor: remove duplicated code and simplify codebase (~330 lines re…
claude Feb 13, 2026
2b9b804
chore: update package-lock.json after dependency install
claude Feb 13, 2026
d8d6a7e
fix: cache CRC32 table, guard console.log with debug flag, fix proces…
claude Feb 13, 2026
3f156a9
chore: bump version to v3.2.1, update changelog
claude Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,7 +1005,20 @@ catch (error) {

## Changelog

### v3.2.0 (Latest) - Major Performance & API Improvements
### v3.2.1 (Latest) - Code Cleanup & Optimizations
- **Eliminated URL Parsing Duplication**: `UrlAnalyzer` class now delegates to pure functions in `url-parser.ts`, removing ~200 lines of duplicated parsing/formatting logic
- **Centralized Constants**: `INSPECT_BASE` constant defined once and imported everywhere (was duplicated in 3 files)
- **Consolidated URL Dispatch**: Extracted shared `decodeMaskedFromAnalyzed()` helper, removing repeated analyze-check-decode patterns across `index.ts`
- **Deduplicated Promise Timeout**: Extracted `waitForReady()` helper in Steam client, eliminating two identical promise-with-timeout blocks
- **CRC32 Performance**: Pre-computed CRC32 lookup table at module load instead of regenerating the 256-entry table on every `createInspectUrl()` call
- **Debug-Guarded Logging**: All `console.log`/`error`/`warn` calls in Steam client and manager now respect the `enableLogging` config flag via `debugLog()`
- **Fixed `processRarity()` Bug**: Unknown string rarity values now throw `EncodingError` instead of silently returning `STOCK` (0)
- **Fixed `cleanExpiredItems()` Performance**: Replaced O(n²) filter+indexOf+splice pattern with single O(n) reverse-iteration pass
- **Fixed Redundant Hex Validation**: Removed unreachable `>2000` length check that shadowed the correct `>4096` check
- **Removed Dead Code**: No-op ternary and deprecated `substr()` replaced with `slice()`
- **~330 lines removed** with zero public API changes - all existing tests pass

### v3.2.0 - Major Performance & API Improvements
- **True Static Methods**: All static convenience functions now use pure functions with zero instance creation
- **Optimized `inspectItem()`**: Uses static methods for masked URLs, requires explicit Steam client for unmasked URLs
- **Enhanced Error Messages**: Actionable suggestions, troubleshooting steps, and alternative solutions in all errors
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cs2-inspect-lib",
"version": "3.2.0",
"version": "3.2.1",
"description": "Enhanced CS2 Inspect URL library with full protobuf support, validation, and error handling",
"main": "dist/index.js",
"types": "dist/index.d.ts",
Expand Down
Loading