Bugfix: Summaries on Windows#14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13: since this commit moved the Summaries prompt string from stdin to a CLI arg, AI summaries have been broken on Windows.
That said: the real source of the problem seems to have been my last PR on this feature where I set
shell: truefor multiple child process calls on Windows. This evidently made Windows CMD unable to handle the newlines in the prompt string, and from what I can tell: it was never necessary in the first place, and might even have had security implications. Claude, ironically, led me wrong on that one 🙃Changes
shell: truechild process argument in several places (all tested to have no impact on Windows)StandaloneMessageHandler.tsto child processes, similar to howSummaryService.tsdoes itChecklist
npm testpassesnpm run lintpassescd webview && npm run build)CHANGELOG.md(if user-facing change)vscode.l10n.t()for i18n