Remove dead member vars from SimpleSerialAnalyzer.h#28
Open
bigjosh wants to merge 1 commit intosaleae:masterfrom
Open
Remove dead member vars from SimpleSerialAnalyzer.h#28bigjosh wants to merge 1 commit intosaleae:masterfrom
bigjosh wants to merge 1 commit intosaleae:masterfrom
Conversation
Remove dead members
Marcus10110
added a commit
that referenced
this pull request
Oct 28, 2024
Contributor
|
Thanks for submitting this, and sorry for the very long delay!
I went ahead and did that here, I still need to test it though: #39 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were probably left over from an older version and are now unreferenced, and could be confusing to newbees looking at this sample template.
Probably best practice to keep all parser state local inside the worker thread anyway? Is there ever a good reason to modify the analyzer and results class headers?