Repository navigation
docs: close the loop on 009, 010 and 011 - #18
Merged
Merged
Conversation
Marks the three shipped specs DONE with the PRs that landed them, so the backlog does not drift back into claiming nothing shipped -- the drift PR #14 just corrected. Records a real deployment gap found while verifying the merged result: adding a feed to config/feeds/ does not add it to the database. A beat resolves feeds from config, so a new source resolves, passes its tests, and fetches nothing until FeedManager.load_feeds_to_database() is run. Five trade outlets were configured, CI was green, and the corpus stayed empty of them. The tool's own coverage command is what surfaced it, reporting 'no feed anywhere in the corpus carried it either'. Corrects two limitations that are no longer true as written: the one-timescale limitation is fixed, and the calibration machinery now exists though nothing has been staked in it yet. The record stays honest about that distinction -- the fix is a mechanism, not a result.
Task 006 permits a person's name to appear as an attribute of a specific document event and never as an accumulated record, on the reasoning that a document attribute expires with the document while a durable row becomes a file on someone. SOURCES.md and a task file are durable artifacts in a public repository, not document events, and both quoted a news headline naming a named federal official in connection with a personnel matter -- leave and reinstatement. That is the precise image the boundary was written to avoid: a public repo belonging to someone who works in this domain, containing the personnel situation of an identifiable official in it. The point both passages were making -- that this feed carries full body text, and that this is the event the beat was blind to -- does not require the name and is preserved without it. The probe config never contained it: the shipped probe is terms ['FedRAMP'] with any_of [['director','administrator'], ['reinstat*','return*','restored']], which finds the story without naming anyone. The boundary held where it was designed in; it failed in prose nobody had applied it to. Note git history retains the original text. This removes it going forward, which is what can be done without a force-push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Housekeeping plus one real finding, from verifying the merged result end to end.
The three shipped specs are marked DONE
009 → #16, 010 → #17, 011 → #15. Same drift #14 just corrected; not recreating it a week later.
A deployment gap the tool caught itself
Adding a feed to
config/feeds/does not add it to the database. A beat resolves feeds from config, so a new source resolves, passes its tests, and CI goes green — but the fetcher reads therss_feedstable, which is only populated byFeedManager.load_feeds_to_database().Five trade outlets were configured by #16. CI was green. The corpus had zero articles from any of them.
What surfaced it was
beat coverage, from #17:After running the sync (
added=5) and fetching:#17 was built to catch exactly this class and caught it on its first real use — against an incomplete deployment of #16, which merged an hour earlier. Recorded in the README's known limitations so the next person adding a feed doesn't lose an afternoon to a green CI and an empty corpus.
Two limitations corrected because they are no longer true