MDL-83243_main: Prevent loss of SCORM progress due to unstable network#13
Closed
sam-smucker wants to merge 2 commits into
Closed
MDL-83243_main: Prevent loss of SCORM progress due to unstable network#13sam-smucker wants to merge 2 commits into
sam-smucker wants to merge 2 commits into
Conversation
sam-smucker
force-pushed
the
MDL-83243_main
branch
from
b0c113f to
f9f4457
Compare
sam-smucker
changed the title
sam-smucker
force-pushed
the
MDL-83243_main
branch
from
f9f4457 to
ffe9ef6
Compare
sam-smucker
force-pushed
the
MDL-83243_main
branch
2 times, most recently
from
dbc7f93 to
71ac4cc
Compare
On pages using the session manager's keepalive logic, an unstable network connection should cause an alert modal to appear warning the user that their learning progress may not be saved. This doesn't always happen because the modal contents must be fetched with a network request. This commit pre-fetches the alert modal on page load to ensure that it is available if network connection is lost, and if two consecutive requests to touch the session fail, the modal will force the user to leave the page, either by reloading or redirection.
When a user is on a SCORM player page and has a persistently unstable network connection, their Moodle session can expire and/or the SCORM package can fail to save their progress. This change will force the user to exit the SCORM player page to avoid losing unsaved progress.
sam-smucker
force-pushed
the
MDL-83243_main
branch
from
71ac4cc to
8a24cf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.