Skip to content

Fix flaky Simulator stream E2E that blocked the 0.57.0 release #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sambitcreate merged 1 commit into from
Oct 16, 2026
Merged

Fix flaky Simulator stream E2E that blocked the 0.57.0 release #508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/e2e/environment-devices-stream.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,8 @@ test.describe("Simulator stream", () => {
await strip.getByRole("tab", { name: "Checkout flow" }).click({ button: "right" });
await page.getByRole("menuitem", { name: "Float over chat" }).click();
await expect(player).toBeVisible();
await expect.poll(async () => (await player.boundingBox())?.x).toBe(floated!.x);
// Compare whole pixels: the dragged frame can sit on a subpixel offset that the restored frame lands on as a whole pixel.
await expect.poll(async () => Math.round((await player.boundingBox())!.x)).toBe(Math.round(floated!.x));
await player.getByRole("button", { name: "Dock device in its tab" }).click();
await expect(player).toHaveCount(0);

Expand Down
Loading