Repository navigation
Refs #BAC-530: Release 1.1.0 - #8
Merged
Merged
Conversation
Covers decorators that read the GraphqlRails test context with `dig`, using graphql_rails' own FakeContext rather than a Hash, and moves the new `graphql_context:` keyword under "Added". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7 and its Copilot comment about
graphql_context&.dig(...).response.contextanddigon the RSpec test context. graphql moves to 2.6.12, because graphql_rails 3.1.1 usesGraphQL::Schema::Visibilityand doesn't load with graphql 2.1.7.graphql_context&.dig(...)on graphql_rails' ownFakeContextinstead of a Hash. The spec fails withoutdigon the context and fails when the context isn't forwarded.graphql_context:keyword under "Added", says graphql_rails 3.1.1 or later is required and mentionsdig.VERSIONto1.1.0and moves[Unreleased]to[1.1.0] - 2026-10-20. The merge commit gets taggedv1.1.0.The
respond_to?(:with_graphql_context)guard was already covered: removing it fails "when the record is not a GraphqlRails model but its type is".Testing done:
bundle exec rspec, 129 examples, 0 failures.🤖 Generated with Claude Code