Fix stat command compatibility for macOS - #29
Merged
samleeney merged 2 commits intoApr 15, 2026
Conversation
`stat -c %Y` is Linux-specific and fails silently on macOS (Darwin), causing the sidebar collector to never write `.sidebar-cache` and the sidebar renderer to never read it. This results in an empty sidebar on macOS. Use `stat -f %m` on Darwin and keep `stat -c %Y` on Linux.
Owner
|
LGTM. Great fix — thanks @zhenya-zhu! |
# Conflicts: # scripts/lib/collect.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stat -c %Yis Linux-specific (GNU coreutils) and fails silently on macOS, where the correct syntax isstat -f %msidebar-collector.sh) to never generate.sidebar-cache, and the sidebar renderer (sidebar.sh) to never read itChanges
scripts/lib/collect.sh: usestat -f %mon Darwin,stat -c %Yon Linuxscripts/sidebar.sh: same fix for the cache mtime checkTest plan