[codex] Clarify Codex hook trust setup - #33
Merged
Conversation
samleeney
marked this pull request as ready for review
May 19, 2026 07:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies the Codex hook setup docs after the hook feature flag update landed in #31.
/hookstrust step required before Codex runs non-managed command hooks..codex/hooks.jsonfile.hooks.json.Why
The setup can appear broken after updating the hook config if Codex has not trusted the command hooks yet. The README now calls out that required review step explicitly.
Validation
bash tests/readme-codex-feature-flag.shbash tests/codex-hook-lifecycle.shbash tests/status-line-codex-regression.shbash -n hooks/codex-hook.sh