Skip to content

Amend final-review authorization target and outcome closure #16

Description

@samovers

Depends on: #10 and the Phase A candidate in #11.

Blocks: #15.

Outcome

Amend the non-authoritative authorization Phase A candidate so final review actions preserve active OFARM review scope and bind the exact result posture needed by the separately owned ReviewDecision protected-effect contract.

Primary trust boundary

Canonical authorization law: the exact authority target and effect-intent content selected for final review actions.

This is separate from #15, which owns ReviewDecision result mappings, event/commit classification, postconditions, and validation evidence.

Triggering contradiction

Active OFARM law defines ReviewDecision as an immutable governance act that changes the in-force status of assertions or accepted event consequences. Current ReviewDecision v0.1 permits ACCEPTED_EVENT_CONSEQUENCE, and a current example exercises REVIEW_SUPERSEDE against that family.

The semantically approved authorization candidate instead assigns all final review actions to RP_REVIEW_TARGET_ONE, whose closed target list omits ACCEPTED_EVENT_CONSEQUENCE. A protected-effect contract cannot restore that target locally without widening authority beyond the selected authorization rule.

The candidate also says the review decision kind is fixed by action class, but REVIEW_REJECT_OR_CONTEST permits two materially different result states. The exact REJECTED versus CONTESTED posture must be bound inside the effect intent so the domain contract can reject substitution.

Intended PR boundary

One bounded amendment to the existing candidate document on PR #11. No accepted RFC, active baseline, current/draft schema, domain result contract, Event Grammar, runtime code, currentness, or OFARM2 change.

Because PR #11 already received steward semantic approval at b0e0409, any amendment requires renewed review and steward approval before #15 resumes.

Acceptance criteria

  • Make ACCEPTED_EVENT_CONSEQUENCE an explicit eligible target for the applicable final review actions without silently widening unrelated action classes.
  • Preserve one concrete authority target and exact immutable target ref/revision or digest.
  • Define the final-review intent outcome posture exactly:
    • REVIEW_ACCEPT binds ACCEPTED;
    • REVIEW_SUPERSEDE binds SUPERSEDED;
    • REVIEW_REJECT_OR_CONTEST requires one intent-bound closed value, REJECTED or CONTESTED.
  • Keep the outcome posture inside the single validated effect intent; no mirrored caller field may select or override it.
  • Add hostile cases for omission/substitution of ACCEPTED_EVENT_CONSEQUENCE targets and REJECTED/CONTESTED result substitution.
  • Update the relevant invariant, traceability entry, steward approval item, and completion criterion.
  • Retain the one-file, draft, non-authoritative PR boundary.

Non-goals

  • No ReviewDecision result schema or protected-effect mapping; Define final ReviewDecision protected-effect contract #15 owns that boundary.
  • No change to who may perform final review or how authority paths are evaluated.
  • No REVIEW_REQUEST commit-class closure.
  • No expansion of read targets or other action classes.
  • No active-law promotion, schema work, runtime implementation, or merge authorization.

What is next: obtain explicit direction to amend PR #11, then renew semantic review and steward approval before resuming #15.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions