Modernize, cleanup, simplify the build system (cmake)#173
Open
mkoloberdin wants to merge 5 commits into
Open
Conversation
mkoloberdin
force-pushed
the
cmake-improve
branch
2 times, most recently
from
fc677d9 to
caa2617
Compare
Set CMAKE_C_STANDARD 17 and CMAKE_CXX_STANDARD 17 globally, removing the hardcoded -std=c++11 and -std=gnu99 flags that conflicted with CMAKE_*_STANDARD. Delete the redundant Qt6-block-only C++17 setting. Fix three bare `inline` functions in C files that became undefined references under C17 inline semantics (C99 always-inlined them): - lr_pref_cb.c: lr_swaph → static inline (file-local) - video.c: vid_dot_full, vid_dot_half → plain (extern via header) Remove dead Qt4 CMake block (EOL 2015, incompatible with C++17). Remove dead SDL1 CMake block (EOL 2012). Add CMAKE_EXPORT_COMPILE_COMMANDS ON for clangd/LSP support.
mkoloberdin
force-pushed
the
cmake-improve
branch
from
caa2617 to
224a367
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake: 3.22 (2021) is reasonable and compatible for most users in 2026.Qt4: not maintained since 2023 - https://zx-pk.ru/threads/9479-xpeccy.html?p=1184146&viewfull=1#post1184146Qt5: >= 5.15 (2020, LTS)SDL1: not maintained; the codebase already assumes SDL2 for joystick events, audio device API.C++17: mandatory for QT6; Qt 5.15 - C++17 support "fully embraced"; supported by both gcc and clang for years.CMAKE_EXPORT_COMPILE_COMMANDS ON- gives clangd (and any LSP client) perfect include paths.