Covariance lemma for exponentiating by (- = 0) - #218
Merged
Conversation
This also involved generalising the lemma to closure of covariance under (f(-) = 0) for any f
samtoth
marked this pull request as ready for review
June 18, 2026 14:17
samtoth
marked this pull request as draft
June 18, 2026 16:35
3 tasks
samtoth
marked this pull request as ready for review
June 24, 2026 08:42
fredrik-bakke
requested changes
Jun 25, 2026
Collaborator
There was a problem hiding this comment.
One thing I notice that you're doing consistently here is prioritising shorter vertical space over
shorter horizontal space in your proofs. There are many reasons to have the opposite priority:
- Mobile phones are long and not wide
- The current approach adds excessive indentation which makes the code less uniform, making it more difficult to discern where "the information" in the proofs is hiding at a glance.
- The shortcuts you take to compress *vertical space are not amenable to refactoring.
For these reasons I'm asking you to change the way you format your proofs in this regard.
Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
Collaborator
|
This is an aside, but the |
fredrik-bakke
approved these changes
Jun 26, 2026
samtoth
added a commit
that referenced
this pull request
Jun 30, 2026
Builds on #218 Extracted from #206 - [x] Adds directed gluing/univalence lemma for covariant families (that no longer relies on having representing object for LFib) - [x] Uses the above lemma for directed univalence for the category of spaces - [x] Extracts lemma about detecting fibrewise equivalences of covariant families so that it doesn't mention spaces --------- Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also makes tr-cov-hom and related lemmas opaque to improve goal display (and maybe performance)
extracted from #206