Skip to content

Remove specific text content assertion for Info popover in E2E tests#100

Merged
samuel-skean merged 1 commit into
devfrom
remove-popover-text-assertion-173859597709416002
Jan 20, 2026
Merged

Remove specific text content assertion for Info popover in E2E tests#100
samuel-skean merged 1 commit into
devfrom
remove-popover-text-assertion-173859597709416002

Conversation

@google-labs-jules
Copy link
Copy Markdown
Contributor

Removed the assertion that checks for specific text content ("Info") in the popover heading within the E2E tests. This makes the tests less brittle to content changes while still verifying that the popover is visible.


PR created automatically by Jules for task 173859597709416002 started by @samuel-skean

- Removed `toHaveText("Info")` assertion in `tests/e2e/ui.spec.ts` to reduce brittleness.
- Kept `toBeVisible()` check to ensure popover opens correctly.
- Removed unused `heading` variable.
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Jan 20, 2026

Deploying speedometer with  Cloudflare Pages  Cloudflare Pages

Latest commit: 353f5c7
Status: ✅  Deploy successful!
Preview URL: https://be512096.speedometer-f1o.pages.dev
Branch Preview URL: https://remove-popover-text-assertio.speedometer-f1o.pages.dev

View logs

@google-labs-jules
Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@samuel-skean samuel-skean marked this pull request as ready for review January 20, 2026 17:43
@samuel-skean samuel-skean merged commit 4788253 into dev Jan 20, 2026
3 checks passed
@samuel-skean samuel-skean deleted the remove-popover-text-assertion-173859597709416002 branch January 20, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant