Skip to content

Fix timestamp mocking in unit tests #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Fix timestamp mocking in unit tests #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "speedometer",
"version": "0.0.81",
"version": "0.0.82",
"description": "Minimal PWA speedometer that displays GPS speed. Includes TypeScript script to render PNG icons from SVG using sharp.",
"license": "MIT",
"private": true,
Expand Down
6 changes: 6 additions & 0 deletions tests/app.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,9 @@ describe("Speedometer App", () => {
// Advance time by 1s (GPS_WARMUP_MS)
vi.advanceTimersByTime(1000);

// Update timestamp to reflect elapsed time
mockPosition.timestamp = Date.now();

// Send it again to trigger the update
watchSuccessCallback(mockPosition as unknown as GeolocationPosition);
} else {
Expand Down Expand Up @@ -218,11 +221,13 @@ describe("Speedometer App", () => {

// Reading 2 (T=0.5s) -> Ignored
vi.advanceTimersByTime(500);
mockPosition.timestamp = Date.now();
watchSuccessCallback(mockPosition as unknown as GeolocationPosition);
expect(speedEl.textContent).toBe(PLACEHOLDER);

// Reading 3 (T=1.0s) -> Accepted (>= GPS_WARMUP_MS)
vi.advanceTimersByTime(500);
mockPosition.timestamp = Date.now();
watchSuccessCallback(mockPosition as unknown as GeolocationPosition);
// 10 m/s * 2.23694 = 22.3694 -> 22
expect(speedEl.textContent).toBe("22");
Expand Down Expand Up @@ -365,6 +370,7 @@ describe("Speedometer App", () => {

// Advance past warmup
vi.advanceTimersByTime(1000);
validPosition.timestamp = Date.now();

// Second one accepted
watchSuccessCallback(validPosition as unknown as GeolocationPosition);
Expand Down