Handle null speed values by showing placeholder#79
Handle null speed values by showing placeholder#79google-labs-jules[bot] wants to merge 10 commits into
Conversation
Updates the geolocation handler to accept `null` speed values (common when stationary or acquiring fix) as valid updates rather than ignoring them. This triggers the UI to display the placeholder text instead of stale speed data, while correctly updating data freshness timestamps to prevent false warnings.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying speedometer with
|
| Latest commit: |
6341583
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0a2f2f81.speedometer-f1o.pages.dev |
| Branch Preview URL: | https://speed-null-handling-92370576.speedometer-f1o.pages.dev |
- Replace static "Got it" button with dynamic button in `#info-popover` - Add `checkPermissions` logic using `navigator.permissions` API - Update popover UI state based on permission status (prompt vs granted) - Use `data-action` attribute for button behavior stability - Ensure popover remains open when asking for permissions - Hide warning message and switch to "Got it" when permissions are granted
- Implement `onLocationSuccess` callback pattern to update popover UI immediately when location data is received. - Fixes issue where popover state would not update after user granted permissions in native prompt. - Ensures consistent "Ask" -> "Granted" transition regardless of browser event limitations (e.g. onchange reliability).
- Moves landscape CSS overrides to the end of the style block to fix specificity issues. - Hides unknown speed message when data becomes stale to avoid visual clutter. - Adds new test case for stale data hiding logic.
…147974545 Add unknown speed message and remove GPS warmup logic
…gic-2853070433236340321 Dynamic Permission Logic in Info Popover
1 participant
handlePositioninsrc/app.tsto processspeed === null.renderSpeedinsrc/app.tsto acceptnumber | null.renderSpeedto callshowPlaceholder()when speed isnull.nullspeed updates to maintain data freshness state.nullspeed.PR created automatically by Jules for task 9237057639772706340 started by @samuel-skean