Corrected path and library for latest SDK as of 3.0.0.118#86
Open
jgonzalez49 wants to merge 3 commits into
Open
Corrected path and library for latest SDK as of 3.0.0.118#86jgonzalez49 wants to merge 3 commits into
jgonzalez49 wants to merge 3 commits into
Conversation
Collaborator
|
This will need to be backwards compatible. Perhaps try different paths until one exists? Also does the update need to happen on other platforms? |
Author
|
The new version includes a check for the old path. It too is tested minimally with success on my system. I can't speak to the path structure for other platforms. |
Added check for new Windows path structure.
Author
|
They changed the path structure on Windows again. New version seems to support the latest Spinnaker version (4.0.0.116 at the time of writing). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I hit bug #64, and I did not see a PR already submitted for this, here is one. It corrects the path for the latest version of the Spinnaker SDK (3.0.0.118 at the time of writing) and adds in the DLL name for the video DLL. It is tested minimally and working for me on Windows 10 with Julia 1.8.5.