docs(reflect): convert design to KEP format#107
Conversation
Signed-off-by: samzong <samzong.lu@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebd38f196e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 4. With no explicit scope outside a Git repository, Reflect defaults to personal | ||
| reflection over a recent time window. |
There was a problem hiding this comment.
Keep the documented default scope implementable
In the current extension, apply_default_scope in extensions/recall-reflect/src/main.rs always calls current_git_root() when neither --project nor --repo is present, and current_git_root() bails outside a worktree; the regression test reflect_cli_requires_explicit_scope_outside_git_worktree asserts this behavior. With this new rule, recall reflect outside a repo is documented as personal reflection, but today it exits with an error, so users/agents following the KEP get a non-working command unless the CLI changes or the default remains explicit-scope.
Useful? React with 👍 / 👎.
|
I read through this KEP version, and I think the personal + project split is the right direction. The first
I suggest we avoid jumping directly to TUI/apply in the next implementation PR, because that would make the PR large and harder to review. I’d split the work into smaller steps:
That lets us make the personal view real quickly while keeping the extension boundary clean: Reflect continues to consume Recall through |
|
Note on merge method: PR #107 was accidentally merged with a regular merge commit instead of the repo-preferred squash merge. The code and checks are fine, but the merge method was not the intended one.\n\nI prepared an equivalent squash replacement commit with the same final tree and tried the safe correction path with |
What's changed?
Why
Verification
git diff --cached --checkgit diff HEAD~1..HEAD --checkawk 'length($0)>100 {print FILENAME ":" FNR ":" length($0) ":" $0}' docs/extensions/reflect.md\n- Pre-ship committed-diff review: no MUST-FIX findings.\n- Rust tests not run; documentation-only change.