Repository navigation
docs+ci: tick M14-07, M13-68 (run 3; review job --max-turns 40); §16.2 CharMacrosReport amendment; M13-73, M13-74 - #295
Merged
Conversation
…3 char binds case-variant wording Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…he M14-03 security review) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…-turns 40 The action fails a run whose num_turns exceeds --max-turns even after a successful result; two of three lab/ runs went past 30 (36, 38). Per the ticket's rule the cap is raised to 40. The earlier paragraph's reading of the failure and its 400 KiB skip claim were wrong (#295 review). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
sandgraal
marked this pull request as ready for review
October 19, 2026 11:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Conductor lane (ADR-0013 amendment, 2026-10-17):
docs/BACKLOG.md,docs/LAB_PLAN.md, and one line of.github/workflows/claude-review.yml.docs/LAB_PLAN.md§16.2: a dated amendment with the finalCharMacrosReportfields as merged (candidate_index,keys_incomplete, the candidate rule's two [verify] marks, the runbook), as the M14-07 implementer and domain-reviewer confirmed them.lab/run of the review job recorded (feat(char): wowlab char macros, and the macro placement candidate rule (M14-07) #292 at 54fd434, run 39240814654: 3 min 22 s,num_turns38, resultsuccess, FINDINGS(1), jobfailurebecause the action fails a run whosenum_turnsexceeds--max-turnseven after a successful result; feat(char): wowlab char gear, and the lossless item-link parser (M14-05) #286 failed the same way at 36). Two of threelab/runs overran 30, so per the ticket's rule--max-turnsgoes from 30 to 40 in.github/workflows/claude-review.yml(the one change the ticket allows): 40 covers both overruns with margin, the docs-side runs used 10 and 11 turns, and alab/run's wall time of about 3.5 minutes bounds the cost. An earlier draft of the record read the failure wrongly and said the cap stays; the docs+ci: tick M14-07, M13-68 (run 3; review job --max-turns 40); §16.2 CharMacrosReport amendment; M13-73, M13-74 #295 review caught it and the paragraph carries a dated correction.char bindswith case-variantWowLab.luafiles and no--character; both M14-07 reviewers, off that branch) and M13-74 (sv merge --expectpins the merged bytes, not only the target; the M14-03 security review, ruled a follow-up by the conductor because M14-03 named the target hash as the pin and allows one new JSON field).Proof
[ ]→[x]changes; two new tickets after M13-72.--max-turns 30→40); permissions, the env scrub, the allowed tools, the model pin, the diff cap and the skip conditions are untouched (narrowsecurity-reviewerpass on the line).mainat 4a5b8db.Reviewed by
code-reviewerFINDINGS(3) at 6c68099 (the run-3 record misread the job failure and claimed a 400 KiB skip; fixed 3fde547) → re-check: record confirmed against the log; title and body updated.security-reviewer(narrow, the workflow line) CLEAN at 3fde547: permissions, env scrub, allowed tools, model pin, diff cap and skip conditions untouched; notimeout-minutesexists to move.session: 284d1153-c891-4b84-8e47-150842fac4ba
🤖 Generated with Claude Code