Skip to content

Work on jupyter notebooks target identification#299

Merged
jehsharp merged 35 commits into
sandialabs:developfrom
jehsharp:work_on_jupyter_notebooks_target_identification
Nov 20, 2025
Merged

Work on jupyter notebooks target identification#299
jehsharp merged 35 commits into
sandialabs:developfrom
jehsharp:work_on_jupyter_notebooks_target_identification

Conversation

@jehsharp
Copy link
Copy Markdown
Collaborator

@jehsharp jehsharp commented Oct 29, 2025

Purpose

The purpose of this pull request is to get all the work associated with finalizing the Jupyter Notebooks into the develop branch. This work included getting the data ready to submit to IR.

Summary of changes

Fixes to Jupyter Notebooks and / or source code in order to get data displayed or saved.

Implementation notes

Please describe any relevant implementation details for reviewers, e.g. how correctness was verified.

Submission checklist

  • Target branch is develop, not main
  • Existing tests are updated or new tests were added
  • opencsp/test/test_DocStringsExist.py are verified to include this change or have been updated accordingly
  • .rst file(s) under doc/ are verified to include this change or have been updated accordingly

Additional information

Please provide any additional information here.

@jehsharp jehsharp requested a review from bbean23 October 29, 2025 15:39
@jehsharp jehsharp changed the base branch from main to develop October 29, 2025 15:41
@jehsharp
Copy link
Copy Markdown
Collaborator Author

jehsharp commented Nov 20, 2025

Okay, this PR is in a good place to merge in. However, the tests are hanging. I need to investigate that first.

The tests were hanging because I was out of sync with a file from Develop, cross_section.ipynb.

@jehsharp jehsharp merged commit e9aba77 into sandialabs:develop Nov 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant