309 code bug incorrect units on enclosed energy example#312
Merged
jehsharp merged 21 commits intoDec 2, 2025
Merged
Conversation
…pixels_transforms() methods, make PerspectiveTransform OpenCSP compliant by adding unit tests and docstrings
…ransforms in CroppingImageProcessor
…_to_pixels_conversion() to PerspectiveTransform
…oordinates_transform
…it tests for ViewCrossSectionImageProcessor, add invert_ylim option to View3d.draw_image()
…or View3dImageProcessor
…to use operable.transform_coordinates() in their visualizations
1 task
jehsharp
approved these changes
Dec 2, 2025
Collaborator
jehsharp
left a comment
jehsharp
left a comment
There was a problem hiding this comment.
Hey Ben, this looks good to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Use the correct units on spot analysis visualizations.
fixes #309
Summary of changes
Implementation notes
Correctness was verified with the addition of new unit tests.
Please note: some of the unit tests for the spot analysis image processors are skipped due to a bug in the way that Matplotlib handles closed plots. There is a note detailing this in these skipped tests.
Submission checklist
develop, notmainopencsp/test/test_DocStringsExist.pyare verified to include this change or have been updated accordinglydoc/are verified to include this change or have been updated accordinglyAdditional information
We're using sympy expressions for the coordinate transforms because they are serializable, which is a key feature of the SpotAnalysisOperable class. We want to maintain its ability to be serialized so that it can be easily multi-processed using the multiprocessing library sometime in the future.