Jeff add rst#322
Merged
Merged
Conversation
…ough rough example_scene_reconstruction.py working from the command line.
…for example_scene_reconstruction.py
…s either for command line or pytest.
… a configuration file.
…for example_scene_reconstruction.py
…s either for command line or pytest.
… a configuration file.
…ough rough example_scene_reconstruction.py working from the command line.
…for example_scene_reconstruction.py
… a configuration file.
…Fixed example_process_single_facet_README.txt file.
…rbose' values set in main.
…e. Included checks for missing parameters, true/false strings, contiguous tokens.
…y. Moved .py files and two example settings configuration files into example/sofast_fringe/single_facet directory.
…ef 25 m, ref plano cases, extended control to allow switching off fringe image output.
…xample_process_single_facet_README.md file.
…ple_process_single_facet.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This extends the example_scene_reconstruction.py and example_process_single_facet.py example scripts to support:
Summary of changes
Implementation notes
Several example settings configuration files were developed to exercise different usage scenarios. These scripts were included in the repo as examples, with in-file comment instructions.
Submission checklist
develop, notmainopencsp/test/test_DocStringsExist.pyare verified to include this change or have been updated accordinglydoc/are verified to include this change or have been updated accordinglyAdditional information
This is needed to enable users to run SOFAST with a structured example, and it avoids the problems associated with copying and editing an example script.
This information is copied from Randy Brost, in PR #321. I, Jeff, built off of that PR to fix the failing doc check. My fixes involved updating config.rst to include the new location of example_process_single_facet (example.sofast_fringe.single_facet.example_process_single_facet). I also worked on updating the docstrings in a few files to meet NumPY doc standards. (example_scene_reconstruction.py, example_process_single_facet.py, & SelectImagePoints.py). I did notice a spurious error, a circular import, that only shows up from time to time. I will get this merged in and create an issue for that error. I will track that down soon.