Notebook config files#324
Merged
Merged
Conversation
…, geared toward running on standard ctemp data locations.
…hen modified enclosed_energy.ipynb to use that capability.
… configuration files with current standard, and also save PowerPoint figure files.
…examples, updated and tested OpenCSP distribution data to reflect new storage organization.
…at works under new storage convention.
jehsharp
approved these changes
Feb 2, 2026
Collaborator
jehsharp
left a comment
There was a problem hiding this comment.
This all looks great, in fact, it looks similar to how I had implemented the code / notebooks to save to PowerpointFigures. Thanks for doing this!
In addition, I reran the failing jobs a couple of times and got the doc-checks to pass. This tells me that it's the same error that I was encountering. I have opened issue #323 so that we can track it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Update SpotAnalysis jupyter notebooks to current standards.
Summary of changes
Brings SpotAnalysis jupyter notebooks up to current file storage convention on ctemp, and also extends them so they store all PowerPoint figure files during the course of execution.
Also updated scene_reconstruction example to follow the new standard.
Implementation notes
This code update proceeds in concert with companion updates in OpenCSP data on the OpenCSP Box site.
Submission checklist
develop, notmainopencsp/test/test_DocStringsExist.pyare verified to include this change or have been updated accordinglydoc/are verified to include this change or have been updated accordingly