Shortened SOFAST output path lengths#326
Merged
Merged
Conversation
…on of view suffix.
…mes. This required replacing reference plot images with new ones.
…es to reflect ctemp use and shortened path convention.
jehsharp
approved these changes
Feb 4, 2026
Collaborator
jehsharp
left a comment
jehsharp
left a comment
There was a problem hiding this comment.
This looks good to me, I will get it merged in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Shortened SOFAST file paths to facilitate OpenCSP data distribution and ctemp use.
Summary of changes
The goal is to support efficient new user initial development using the ctemp directory. Implementing the data set for release revealed that the current file naming convention produced overall path lengths that would not unzip in the ctemp directory.
In response, I trimmed the paths by both topological simplification and also reducing the length of both directory and file names.
This in turn required some minor changes to the figure management utility, and also replacement of the expected figures, since both their names and contents changed, causing pytests to fail.
After these updates, the distribution to ctemp proceeds smoothly, and both pytest and manual exercise succeeded.
The required data set will be submitted for approval to release to OpenCSP_Data.
Implementation notes
Pytest and manual exercise of the example_process_single_facet script on the six different example SOFAST run configurations.
Submission checklist
develop, notmainopencsp/test/test_DocStringsExist.pyare verified to include this change or have been updated accordinglydoc/are verified to include this change or have been updated accordingly