Ensure environment is active before concretizing - #662
Merged
Conversation
sebrowne
force-pushed
the
main
branch
2 times, most recently
from
July 23, 2026 17:23
e054e58 to
53f373a
Compare
Whether or not it needs to be is still somewhat unclear to me, but the behavior when not active was definitely missing pieces of the configuration. Activating it via context manager prior to concretizing seems perfectly fine and fixes the issues I'm seeing. Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
sebrowne
force-pushed
the
main
branch
2 times, most recently
from
July 23, 2026 20:19
dc790dd to
7e6b20e
Compare
Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
Works on old and new versions of Spack. Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
sebrowne
force-pushed
the
main
branch
2 times, most recently
from
July 27, 2026 12:55
6d49c2f to
bcecb35
Compare
Spack added a concretization cache plugin for pytest with spack/spack#52717, which requires all extensions to load as well (extensions don't get the root-level spack conftest.py). Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
Concretization settings matter in the generated environment, and were recently changed to have the environment be active prior to setting them. So assert on them in the relevant environment as well. Signed-off-by: Samuel E. Browne <sebrown@sandia.gov>
sebrowne
enabled auto-merge (squash)
July 27, 2026 19:42
jnhealy2
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whether or not it needs to be is still somewhat unclear to me, but the behavior when not active was definitely missing pieces of the configuration. Activating it via context manager prior to concretizing seems perfectly fine and fixes the issues I'm seeing.
Also added compatibility fixes for current Spack
developversion.