-
Notifications
You must be signed in to change notification settings - Fork 34
Y26 031 labware location report by retention instructions #5637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wendyyang
wants to merge
30
commits into
develop
Choose a base branch
from
Y26-031---labware-location-report-by-retention-instructions
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
a5b5a47
save changes
wendyyang e446636
save change
wendyyang 99653c3
remove retention instruction param
wendyyang 67bc87f
save changes
wendyyang fc408a1
save changes
wendyyang 31159ad
refactor
wendyyang 0b1e94f
merge develop in and resolve conflict
wendyyang 77a9e04
add tests
wendyyang a2a9912
fix the typo
wendyyang 7e4e26f
fix the typo
wendyyang 8a8178f
refactor test
wendyyang 81e643c
update the new column type
wendyyang ef88f72
fix the test
wendyyang 9b13bb4
fix tests
wendyyang c010b3d
Merge branch 'develop' into Y26-031---labware-location-report-by-rete…
wendyyang d767076
Merge branch 'develop' into Y26-031---labware-location-report-by-rete…
wendyyang f150c6f
merge develop in
wendyyang de897c4
Merge branch 'develop' into Y26-031---labware-location-report-by-rete…
wendyyang e973767
Merge branch 'develop' into Y26-031---labware-location-report-by-rete…
wendyyang 1f63913
move filter in the scope
wendyyang bb4db65
Merge branch 'develop' into Y26-031---labware-location-report-by-rete…
wendyyang cd2be93
Merge branch 'develop' into Y26-031---labware-location-report-by-rete…
wendyyang 2b9a0cf
refactor search_for_labware_by_selection
wendyyang b572c92
fix the test
wendyyang eab5820
fix linting
wendyyang 9cc102e
Merge branch 'develop' into Y26-031---labware-location-report-by-rete…
wendyyang d233cf9
refactor the tests
wendyyang 1851e07
Merge branch 'develop' into Y26-031---labware-location-report-by-rete…
wendyyang b91b6ca
rename the plate_3_return_customer
wendyyang 4d1e8fb
Merge branch 'develop' into Y26-031---labware-location-report-by-rete…
wendyyang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
db/migrate/20260325134057_add_retention_instructions_to_location_reports.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # frozen_string_literal: true | ||
| class AddRetentionInstructionsToLocationReports < ActiveRecord::Migration[7.2] | ||
| def change | ||
| add_column :location_reports, :retention_instructions, :string | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.