Skip to content

Y26-085 submission template for ultima ug200 sequencing#5645

Merged
yoldas merged 34 commits intodevelopfrom
Y26-085-submission_template-for-ultima-ug200-sequencing
Apr 13, 2026
Merged

Y26-085 submission template for ultima ug200 sequencing#5645
yoldas merged 34 commits intodevelopfrom
Y26-085-submission_template-for-ultima-ug200-sequencing

Conversation

@andrewsparkes
Copy link
Copy Markdown
Member

Closes #4657

Changes proposed in this pull request

Adds submission template and associated changes

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.22%. Comparing base (70091f7) to head (489243c).
⚠️ Report is 35 commits behind head on develop.

Files with missing lines Patch % Lines
app/models/ultima_ug200_sequencing_request.rb 92.85% 1 Missing ⚠️
app/validators/ultima_ug200_validator.rb 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5645      +/-   ##
===========================================
- Coverage    87.28%   87.22%   -0.06%     
===========================================
  Files         1463     1466       +3     
  Lines        33061    33092      +31     
  Branches      3483     3485       +2     
===========================================
+ Hits         28857    28865       +8     
- Misses        4183     4206      +23     
  Partials        21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@KatyTaylor KatyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a surprising amount of stuff that needed to be added!

I've left a few minor comments, nothing blocking.

If was deployed like this:

  • Would add Wafer Size column to bulk submission spreadsheets
  • Would add Wafer Size column to request metadata
  • Would not expose new submission template or pipeline inbox page (WIP'd)

--> which seems OK to me.

Comment thread app/models/ultima_ug200_sequencing_pipeline.rb
Comment thread app/validators/ultima_ug200_validator.rb Outdated
Comment thread config/default_records/request_types/026_ultima_ug200_request_types.wip.yml Outdated
@yoldas yoldas merged commit 8edd722 into develop Apr 13, 2026
28 checks passed
@yoldas yoldas deleted the Y26-085-submission_template-for-ultima-ug200-sequencing branch April 13, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants