Skip to content

[dev] Removes dependency lock on Psych#5681

Open
StephenHulme wants to merge 31 commits intodevelopfrom
sh51/remove-pysch-dependency
Open

[dev] Removes dependency lock on Psych#5681
StephenHulme wants to merge 31 commits intodevelopfrom
sh51/remove-pysch-dependency

Conversation

@StephenHulme
Copy link
Copy Markdown
Contributor

@StephenHulme StephenHulme commented Apr 10, 2026

Resolves a dependency conflict on Psych <4 and Rails 7+.

Changes proposed in this pull request

  • The staus quo is unsafe YAML file loading
  • Removes dependency lock on Psych
  • Use updated record_loader version (TODO: link to 1.0.1)
  • Update usage of YAML fileloading to explictly declare whether files are loaded safely, or unsafely
  • Update context in bulk submission tests
  • Repair typo in asset shape record loaders

Requires sanger/record_loader#54

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme StephenHulme changed the title [ruby] Remove unused pysch dependency [ruby] Removes dependency lock on Psych Apr 10, 2026
@StephenHulme StephenHulme changed the title [ruby] Removes dependency lock on Psych [dev] Removes dependency lock on Psych May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.28%. Comparing base (3b98d61) to head (49b7688).
⚠️ Report is 103 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5681      +/-   ##
===========================================
- Coverage    87.33%   87.28%   -0.05%     
===========================================
  Files         1473     1476       +3     
  Lines        33399    33519     +120     
  Branches      3531     3549      +18     
===========================================
+ Hits         29169    29258      +89     
- Misses        4209     4240      +31     
  Partials        21       21              
Flag Coverage Δ
javascript 50.00% <ø> (ø)
ruby 87.29% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@StephenHulme StephenHulme self-assigned this May 5, 2026
@StephenHulme StephenHulme added the dependencies Pull requests that update a dependency file label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant