Skip to content

y26-118 mysql 8.4 testing#5702

Open
andrewsparkes wants to merge 7 commits intodevelopfrom
y26-118-mysql-8p4-update-testing
Open

y26-118 mysql 8.4 testing#5702
andrewsparkes wants to merge 7 commits intodevelopfrom
y26-118-mysql-8p4-update-testing

Conversation

@andrewsparkes
Copy link
Copy Markdown
Member

Changes to accommodate mysql 8.4
Re-added PlateTemplate api v2 resource

Closes #5673

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.28%. Comparing base (03dff92) to head (562ab51).

Files with missing lines Patch % Lines
app/controllers/plate_templates_controller.rb 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5702      +/-   ##
===========================================
- Coverage    87.30%   87.28%   -0.02%     
===========================================
  Files         1467     1469       +2     
  Lines        33167    33180      +13     
  Branches      3496     3496              
===========================================
+ Hits         28955    28960       +5     
- Misses        4191     4199       +8     
  Partials        21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@BenTopping BenTopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.
Why did plate templates resource need restoring, is it used somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants