Skip to content

deprecate LRC Bank input tube purpose#5739

Open
sabrine33 wants to merge 1 commit intodevelopfrom
Y26-075
Open

deprecate LRC Bank input tube purpose#5739
sabrine33 wants to merge 1 commit intodevelopfrom
Y26-075

Conversation

@sabrine33
Copy link
Copy Markdown
Contributor

Closes #5602

Changes proposed in this pull request

  • We can filter the acceptable_purposes list by LRC Bank Input in the Ruby model, but updating the schema would be preferable as it enforces data integrity and provides a more scalable foundation for future extensions.
  • Did not add tests as not much logic is done here.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.27%. Comparing base (2079c8f) to head (863eadb).

Files with missing lines Patch % Lines
lib/tasks/deprecate_lrc_bank_input_purpose.rake 33.33% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5739      +/-   ##
===========================================
- Coverage    87.34%   87.27%   -0.07%     
===========================================
  Files         1474     1475       +1     
  Lines        33412    33421       +9     
  Branches      3533     3534       +1     
===========================================
- Hits         29183    29169      -14     
- Misses        4208     4231      +23     
  Partials        21       21              
Flag Coverage Δ
javascript 50.00% <ø> (ø)
ruby 87.29% <45.45%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y26-075 - Inactivate Legacy LRC Bank Input Tube Purpose

1 participant