Skip to content

Fix buffer overflow in fscan_pnm_token (pnm2png) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sanjay20m wants to merge 1 commit into from
Closed

Fix buffer overflow in fscan_pnm_token (pnm2png) #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion contrib/pngminus/pnm2png.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,11 @@ int fscan_pnm_token (FILE *pnm_file, char *token_buf, size_t token_buf_size)
}
while ((ret == '\n') || (ret == '\r') || (ret == ' '));

/* read string */
do
{
while ((ret == '\n') || (ret == '\r') || (ret == ' '));

/* read string */
do
{
Expand All @@ -560,7 +565,7 @@ while ((ret == '\n') || (ret == '\r') || (ret == ' '));
}
while ((ret != '\n') && (ret != '\r') && (ret != ' '));

token_buf[i] = '\0'; // TO NULL-TERMINATE
token_buf[i] = '\0'; // TO NULL-TERMINATE

return (i > 0) ? 1 : 0;
}
Expand Down